[PATCH] D57082: [HotColdSplit] Move splitting earlier in the pipeline

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/test/Other/opt-hot-cold-split.ll:30
+; DEFAULT-Os-NEXT:     Dead Argument Elimination
+; DEFAULT-Os-NEXT:     Hot Cold Splitting
+; DEFAULT-Os-NEXT:       Unnamed pass: implement Pass::getPassName()
----------------
vsk wrote:
> tejohnson wrote:
> > Suggest cutting the expected output here and in the pre-link cases down to just look for Hot Cold Splitting. Otherwise this test will need to be changed for unrelated opt pipeline changes. And I don't think we need to check the whole pipeline? 
> I'll trim this down, and just check the higher-level invariants described earlier (i.e., after mem2reg, before function simplification passes), if that's all right.
Sure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57082/new/

https://reviews.llvm.org/D57082