[PATCH] D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 12:25:59 PST 2019


delcypher marked an inline comment as done.
delcypher added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_vm_read_context_config.h:1
+//===-- sanitizer_vm_read_context_config.h ----------------------*- C++ -*-===//
+//
----------------
@vitalybuka I had a go at adding `VMReadContextConfig` (see the header file below). The advantage of this is I'm able to pull the definition of `task_t` out of `sanitizer_internal_defs.h` and make the constructor of `VMReadContextConfig` a little nicer by not having it take a `void*`.



Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56206/new/

https://reviews.llvm.org/D56206





More information about the llvm-commits mailing list