[PATCH] D57073: allow COFF .def directive in inline assembly when using ThinLTO

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: clang/test/CodeGen/inline-asm-coff.c:3-4
+// RUN: llvm-readobj -t %t.obj | FileCheck %s
+// RUN: %clang_cl -flto=thin -c %s -o %t.thinlto.ll
+// RUN: %clang_cl -c %t.thinlto.ll -o %t.thinlto.obj
+// RUN: llvm-readobj -t %t.thinlto.obj | FileCheck %s
----------------
This test isn't going to do the right thing on Windows ARM, and I don't think we need this high-level of an integration test.

I'd recommend writing a .ll test similar to the llvm/test/Transforms/ThinLTOBitcodeWriter/symver.ll one. You should be able to use the same assembly as module level asm in LLVM IR, and exercise the same behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57073/new/

https://reviews.llvm.org/D57073