[PATCH] D57052: [IPCP] Don't crash due to arg count mismath between caller/callee

Wed Jan 23 09:18:05 PST 2019

jdoerfert added a comment.

In D57052#1367472 <https://reviews.llvm.org/D57052#1367472>, @bjope wrote:

> In D57052#1366530 <https://reviews.llvm.org/D57052#1366530>, @jdoerfert wrote:
>
> > I see your point and I acknowledge it is a problem. However, I'm not sure a check in IPCP and consequently later in other IPOs is the best solution.
> >  While I have some ideas on how to deal with this (one is to not create call sites for this situation), I think we can go ahead with your local fix now,
> >  keep the test case and make it more general as needed.
> >
> > Long story short, LGTM.
> >
> > One thing, can you mention that this problem was exposed by the fact that AbstractCallSites will look through the bitcast at the callee position of a call/invoke somewhere?
>
>
> Thanks, I added that info to the summary. Now waiting to get my commit access back (seems like our legal department haven't signed the new license agreement yet... so this can't be landed yet... any day now...).

If it is urgent, I can commit it for you. If not, we can just wait.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57052/new/

https://reviews.llvm.org/D57052