[PATCH] D57030: [CommandLine] Don't print empty sentinel values from EnumValN lists in help text
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 23 04:48:51 PST 2019
jhenderson added a comment.
In D57030#1367399 <https://reviews.llvm.org/D57030#1367399>, @thopre wrote:
> To be able to list ='' for sentinel value which are not ValueOptional.
Thinking about it, I have a slight concern that adding the quotes could cause confusion, because theoretically a valid value could iteslf have quotes in, so this makes the help text ambiguous: does the value include the quotes either end or not? How about `=<empty>` for the "sentinel" value?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57030/new/
https://reviews.llvm.org/D57030
More information about the llvm-commits
mailing list