[PATCH] D57088: Add information about unit tests to the testing guide

Carey Williams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 03:33:54 PST 2019


carwil added a comment.

Thanks for posting this! Always good to doc updates.
Bit of _very_ opinionated bit of bike-shedding.  Content otherwise LGTM!



================
Comment at: docs/TestingGuide.rst:101
 
-The tests are located in two separate Subversion modules. The
-regressions tests are in the main "llvm" module under the directory
-``llvm/test`` (so you get these tests for free with the main LLVM tree).
-Use ``make check-all`` to run the regression tests after building LLVM.
+The tests are located in two separate Subversion modules. The unit &
+regression tests are in the main "llvm" module under the directories
----------------
This is incredibly picky, but I'd prefer an 'and' here.


================
Comment at: docs/TestingGuide.rst:104
+``llvm/unittests`` and ``llvm/test`` (so you get these tests for free with the
+main LLVM tree). Use ``make check-all`` to run the unit & regression tests after
+building LLVM.
----------------
ditto.


================
Comment at: docs/TestingGuide.rst:110
 
-Regression tests
-----------------
+Unit & regression tests
+-----------------------
----------------
ditto (perhaps with a capital R, as well).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57088/new/

https://reviews.llvm.org/D57088





More information about the llvm-commits mailing list