[PATCH] D55839: [elfabi] Add support for writing ELF header for binary stubs

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

One small comment from me, otherwise looks good from my point of view, assuming the other reviewers are happy.



================
Comment at: llvm/tools/llvm-elfabi/ELFObjHandler.cpp:264-265
+  ElfHeader.e_ehsize = sizeof(Elf_Ehdr);
+  ElfHeader.e_phentsize = sizeof(Elf_Phdr);
+  ElfHeader.e_shentsize = sizeof(Elf_Shdr);
+}
----------------
Now that you are doing this, please make sure that it is tested too.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55839/new/

https://reviews.llvm.org/D55839