[PATCH] D57016: [llvm-readelf] Stop suppressing static symbol output when --dyn-symbols is specified with --symbols

[James Henderson via Phabricator via llvm-commits]

jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3181
+    return;
   this->dumper()->printSymbolsHelper(true);
+  if (PrintSymbols)
----------------
rupprecht wrote:
> IIUC, printSymbols(/*PrintSymbols=*/true, /*PrintDynamicSymbols=*/false) will still print dynamic symbols here, is that intentional? I think it is, based on the patch description of rL287786 -- if so, can you leave a comment somewhere, maybe also mention it in command line help string?
Sure, I can add a comment. It is intentional, since GNU readelf prints both static and dynamic symbol tables in this case. Not sure I can easily mention it in the help string, since it only affects GNU output style and not LLVM style, but I'll see if I can come up with a way.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57016/new/

https://reviews.llvm.org/D57016