[PATCH] D57009: [llvm-objcopy] [COFF] Fix handling of aux symbols for big objects

Wed Jan 23 01:41:01 PST 2019

mstorsjo added a comment.

In D57009#1366076 <https://reviews.llvm.org/D57009#1366076>, @jhenderson wrote:

> > Other llvm-objcopy reviewers: I'd like to add a custom hidden option for testing, for triggering using the big object format. Without that, a test would have to create over 32k sections to trigger that.
>
> I'm not a fan of adding hidden options purely for testing when there are alternatives. In the ELF tests, we use a pre-built zip file containing an object with many sections (see ELF/many-sections.test). I think you could probably do the same thing here.

I'm experimenting with crafting such an input file now. The uncompressed object file weighs in at around 5 MB, and after gzip (as is used for that ELF test) it currently ends up at around 725 KB. Do you think that's acceptable or too large?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57009/new/

https://reviews.llvm.org/D57009