[PATCH] D56942: Change TPI Bucket size for PDBs from minimum to maximum

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

When I apply this change locally, I get some test failures in LLD.  Essentially, if you run `llvm-pdbutil dump -types -type-extras foo.pdb` we do some sort of crude hash verification.  Basically, we take the hash that is in the PDB, then recompute what we think the hash should be, then compare the two, and if they're not equal we indicate that with a message.  This message is trigger in the LLD tests, which makes me think that either something is wrong with the test, or something is wrong with the way we do the hash verification.

I'll have more time to see which one of these it is tomorrow.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56942/new/

https://reviews.llvm.org/D56942