[PATCH] D53355: Introducing VPPHINode
Nikolay Panchenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 22 15:27:25 PST 2019
npanchen added a comment.
In D53355#1270077 <https://reviews.llvm.org/D53355#1270077>, @rengolin wrote:
> Hi Nikolay,
>
> For what you describe, the patch looks good, ie. create a VPPHIInst. But it doesn't clearly show the benefits of doing so.
>
> I can imagine that it would simplify reasoning and, as you say, avoid creating temporary instructions if not needed, but it would be good to have an example to base that claim.
>
> Do you have the next patch somewhere? Would be good to put it in Phab, so we could look at it and make this review easier.
>
> Thanks!
> --renato
Hi Renato,
Sorry for this long reply. As Satish has pointed out in his review <https://reviews.llvm.org/D53349>, this VPPHINode will be used to generate blending.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53355/new/
https://reviews.llvm.org/D53355
More information about the llvm-commits
mailing list