[PATCH] D57030: [CommandLine] Don't print empty sentinel values from EnumValN lists in help text

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D57030#1366269 <https://reviews.llvm.org/D57030#1366269>, @jhenderson wrote:

> In D57030#1366088 <https://reviews.llvm.org/D57030#1366088>, @thopre wrote:
>
> > Thanks for the explanation. In that case I'd like to differentiate between the optional and non optional case.
> >
> > 1. For optional omitting the line is probably fine, or perhaps put a [default] instead of empty equal sign.
> > 2. To handle the non optional case I think we should introduce single quotes after the equal sign to indicate that this is not an error but an empty value, ie. =''. Perhaps also put quote around other values for consistency.
> >
> >   Does that make sense?
>
>
> I'm afraid I'm not quite sure what you mean by the "optional and non optional case". Do you mean when ValueOptional is and is not used?


Yes my bad, that is what I meant: 1) is when ValueOptional is used, 2) is when it isn't.

Best regards,

Thomas


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57030/new/

https://reviews.llvm.org/D57030