[PATCH] D56986: COFF, ELF: ICF: Perform 2 rounds of relocation hash propagation.

Tue Jan 22 14:07:21 PST 2019

dmajor added a comment.

In D56986#1366881 <https://reviews.llvm.org/D56986#1366881>, @smeenai wrote:

> In D56986#1366874 <https://reviews.llvm.org/D56986#1366874>, @pcc wrote:
>
> > In D56986#1366859 <https://reviews.llvm.org/D56986#1366859>, @smeenai wrote:
> >
> > > Is this worth picking over to 8.0 after it lands?
> >
> >
> > I'm more ambivalent about this one since it's more of a perf improvement than a fix for a perf regression like D56955 <https://reviews.llvm.org/D56955> is. But I have no strong objections to doing so.
>
>
> That's fair; we can just cherry-pick it to our 8.0 branch internally if it doesn't end up merged here :) It's early in the release cycle though, so I figured it was okay for small-ish changes like this which result in big improvements to go in.

FWIW I was hoping to see this be merged to 8.0 as well.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56986/new/

https://reviews.llvm.org/D56986