[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 11:59:53 PST 2019


phosek created this revision.
phosek added reviewers: beanz, chandlerc, tstellar, pcc.
Herald added subscribers: llvm-commits, kristina, mgorny.

Previously, there were two different scripts for generating VCS headers:
one used by LLVM and one used by Clang. They were both similar, but
different. They were both broken in their own ways, for example the one
used by Clang didn't properly handle monorepo resulting in an incorrect
version information reported by Clang.

This change unifies two the scripts by introducing a new script that's
used from both LLVM and Clang, ensures that the new script supports both
monorepo and standalone SVN and Git setups, and removes the old scripts.


Repository:
  rL LLVM

https://reviews.llvm.org/D57063

Files:
  clang/lib/Basic/CMakeLists.txt
  clang/lib/Basic/Version.cpp
  llvm/CMakeLists.txt
  llvm/cmake/modules/GenerateVersionFromCVS.cmake
  llvm/cmake/modules/GenerateVersionFromVCS.cmake
  llvm/cmake/modules/GetSVN.cmake
  llvm/cmake/modules/VersionFromVCS.cmake
  llvm/include/llvm/Support/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57063.182957.patch
Type: text/x-patch
Size: 22000 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190122/8f498095/attachment-0001.bin>


More information about the llvm-commits mailing list