[PATCH] D56835: GlobalISel: Make buildConstant handle vectors

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added a comment.

Could you please add a test case for the vector build constant case? I suspect unless there is already a target to use this, unit test might be the only way.



================
Comment at: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:262
+
+    auto MIB = buildInstr(TargetOpcode::G_BUILD_VECTOR);
+    Res.addDefToMIB(*getMRI(), MIB);
----------------
Any reason for not using buildBuildVector here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56835/new/

https://reviews.llvm.org/D56835