[PATCH] D57016: [llvm-readelf] Stop suppressing static symbol output when --dyn-symbols is specified with --symbols

[James Henderson via Phabricator via llvm-commits]

jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: tools/llvm-readobj/COFFDumper.cpp:1397
+    printDynamicSymbols();
+}
+
----------------
sbc100 wrote:
> Why not keep this as the default implementation rather than duplicating it 3 times?  Of the 4 object formats it looks like only ELF needs different behaviour.
The aim was to remove `printDynamicSymbols` completely from the public interface, but I guess I could put it as a private member in the interface instead.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57016/new/

https://reviews.llvm.org/D57016