[PATCH] D57046: [llvm-symbolizer] Allow single letter command flags grouping.

[Dmitry Venikov via Phabricator via llvm-commits]

Quolyk updated this revision to Diff 182904.
Quolyk added a comment.

Move test to separate file. 
llvm/test/tools/llvm-symbolizer/ and llvm/test/DebugInfo/llvm-symbolizer* pass successfully.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57046/new/

https://reviews.llvm.org/D57046

Files:
  test/tools/llvm-symbolizer/flag-grouping.test
  tools/llvm-symbolizer/llvm-symbolizer.cpp


Index: tools/llvm-symbolizer/llvm-symbolizer.cpp
===================================================================
--- tools/llvm-symbolizer/llvm-symbolizer.cpp
+++ tools/llvm-symbolizer/llvm-symbolizer.cpp
@@ -59,7 +59,7 @@
 ClDemangle("demangle", cl::init(true), cl::desc("Demangle function names"));
 static cl::alias
 ClDemangleShort("C", cl::desc("Alias for -demangle"),
-                cl::NotHidden, cl::aliasopt(ClDemangle));
+                cl::NotHidden, cl::aliasopt(ClDemangle), cl::Grouping);
 static cl::opt<bool>
 ClNoDemangle("no-demangle", cl::init(false),
              cl::desc("Don't demangle function names"));
@@ -99,7 +99,7 @@
                              cl::NotHidden, cl::aliasopt(ClPrintAddress));
 static cl::alias
 ClPrintAddressAliasA("a", cl::desc("Alias for -print-address"),
-                     cl::NotHidden, cl::aliasopt(ClPrintAddress));
+                     cl::NotHidden, cl::aliasopt(ClPrintAddress), cl::Grouping);
 
 // -pretty-print, -p
 static cl::opt<bool>
@@ -107,7 +107,7 @@
                   cl::desc("Make the output more human friendly"));
 static cl::alias ClPrettyPrintShort("p", cl::desc("Alias for -pretty-print"),
                                     cl::NotHidden,
-                                    cl::aliasopt(ClPrettyPrint));
+                                    cl::aliasopt(ClPrettyPrint), cl::Grouping);
 
 static cl::opt<int> ClPrintSourceContextLines(
     "print-source-context-lines", cl::init(0),
Index: test/tools/llvm-symbolizer/flag-grouping.test
===================================================================
--- /dev/null
+++ test/tools/llvm-symbolizer/flag-grouping.test
@@ -0,0 +1,7 @@
+RUN: llvm-symbolizer -inlining -apC -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
+
+CHECK: some text
+CHECK: {{[0x]+}}40054d: inctwo at {{[/\]+}}tmp{{[/\]+}}x.c:3:3
+CHECK:  (inlined by) inc at {{[/\]+}}tmp{{[/\]+}}x.c:7:0
+CHECK   (inlined by) main at {{[/\]+}}tmp{{[/\]+}}x.c:14:0
+CHECK: some text2
\ No newline at end of file


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57046.182904.patch
Type: text/x-patch
Size: 2022 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190122/8eb405bd/attachment.bin>