[PATCH] D56081: [LoopPredication] Support explicit guards

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev marked 4 inline comments as done.
mkazantsev added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopPredication.cpp:651
+  LLVM_DEBUG(dbgs() << "Processing explicit guard:\n");
+  LLVM_DEBUG(Guard->dump());
+
----------------
reames wrote:
> Remove
It is the same printout as in the function above. Why would I remove it?


================
Comment at: lib/Transforms/Scalar/LoopPredication.cpp:662
+  // resulting list of subconditions in Checks vector.
+  BinaryOperator *GuardCondition = cast<BinaryOperator>(Guard->getCondition());
+  auto *Cond = GuardCondition->getOperand(0);
----------------
reames wrote:
> You repeat this logic a bunch of time (across patches).  Factor out a matcher.
https://reviews.llvm.org/rL351803


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56081/new/

https://reviews.llvm.org/D56081