[PATCH] D57007: [llvm-objcopy] [COFF] Implement --add-gnu-debuglink

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/trunk/tools/llvm-objcopy/COFF/Writer.cpp:292-293
 
     // For executable sections, pad the remainder of the raw data size with
     // 0xcc, which is int3 on x86.
     if ((S.Header.Characteristics & IMAGE_SCN_CNT_CODE) &&
----------------
I didn't spot this earlier, but why are you padding assuming it is x86?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57007/new/

https://reviews.llvm.org/D57007