[PATCH] D57007: [llvm-objcopy] [COFF] Implement --add-gnu-debuglink

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked 4 inline comments as done.
mstorsjo added inline comments.


================
Comment at: tools/llvm-objcopy/COFF/Object.h:46
+  // instead of OrigContents above.
+  std::vector<uint8_t> Contents;
 };
----------------
jhenderson wrote:
> Thinking about this a bit more, I wonder if it would be a good idea for there to be a `getContents` function that decides which to fetch. This feels like a potential risk point for bugs, if people try to get `Contents` when it is owned by `OrigContents`. You'd want to make them both private as a result, and therefore add some setters too.
Right, that makes the code much clearer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57007/new/

https://reviews.llvm.org/D57007