[PATCH] D52109: [TwoAddressInstructionPass] Don't update SrcRegMap for copies inserted for tied register constraint when the src isn't killed

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 02:03:54 PST 2019


bjope added a comment.

In D52109#1266142 <https://reviews.llvm.org/D52109#1266142>, @bjope wrote:

> Have you considered making a `.mir`-test that show the effect of TwoAddressInstruction pass here. Maybe an overkill since there already are plenty of test cases that are affected by the change, but it would make it easier to understand the tranformation difference that we introduce in the TwoAddressInstructionPass.


I still got a feeling that a `.mir`-test could be nice. Is that something that you are planning to add or do you disagree?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52109/new/

https://reviews.llvm.org/D52109





More information about the llvm-commits mailing list