[PATCH] D56074: [NFC] Add detector function for explicitly expressed guards

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 21 21:00:22 PST 2019


mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: lib/Analysis/GuardUtils.cpp:30
+  // deopt:
+  //   <non-side-effecting instructions>
+  //   deoptimize()
----------------
apilipenko wrote:
> Why do we need this restriction?
The simplest example is that there is a throwing call before the deopt, we may never actually go to deopt, and this is not what we want here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56074/new/

https://reviews.llvm.org/D56074





More information about the llvm-commits mailing list