[PATCH] D56875: [DAGCombiner] narrow vector binop with 2 insert subvector operands

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 21 11:14:21 PST 2019


spatel planned changes to this revision.
spatel added a comment.

Actually, this patch isn't correct as-is. We can't insert into an undef base vector because at least 'xor undef, undef --> 0' (not undef). 
I know I avoided or fixed the similar problem in IR somewhere along the way.
We need to actually compute the constant vector for the specified binop's opcode.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56875/new/

https://reviews.llvm.org/D56875





More information about the llvm-commits mailing list