[llvm] r351758 - gn build: Stop passing -DLLVM_LIBXML2_ENABLED to some targets

[Nico Weber via llvm-commits]

Author: nico
Date: Mon Jan 21 10:59:11 2019
New Revision: 351758

URL: http://llvm.org/viewvc/llvm-project?rev=351758&view=rev
Log:
gn build: Stop passing -DLLVM_LIBXML2_ENABLED to some targets

This is a remnant from before the gn build had a working config.h.

Defining LLVM_LIBXML2_ENABLED only for targets that depend on build/libs/xml is
nice in that only some of the codebase needs to be rebuilt when
llvm_enable_libxml2 changes -- but config.h already defines it and defining it
there and then redundantly a second time for some targets is worse than having
it just in config.h.

No behavior change.

Differential Revision: https://reviews.llvm.org/D56908

Modified:
    llvm/trunk/utils/gn/build/libs/xml/BUILD.gn

Modified: llvm/trunk/utils/gn/build/libs/xml/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/build/libs/xml/BUILD.gn?rev=351758&r1=351757&r2=351758&view=diff
==============================================================================
--- llvm/trunk/utils/gn/build/libs/xml/BUILD.gn (original)
+++ llvm/trunk/utils/gn/build/libs/xml/BUILD.gn Mon Jan 21 10:59:11 2019
@@ -3,7 +3,6 @@ import("//llvm/utils/gn/build/mac_sdk.gn
 
 config("xml_config") {
   visibility = [ ":xml" ]
-  defines = [ "LLVM_LIBXML2_ENABLED" ]
   libs = [ "xml2" ]
   if (host_os == "mac") {
     include_dirs = [ "$mac_sdk_path/usr/include/libxml2" ]