[PATCH] D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations

Tom Weaver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 21 09:35:24 PST 2019


TWeaver marked an inline comment as done.
TWeaver added inline comments.


================
Comment at: lib/CodeGen/RegisterCoalescer.cpp:1668
+
+  // We now have whether src and dst are live. Best case: we have a DBG_VALUE
+  // of a live register, coalesing won't change its value.
----------------
I believe theres a typo in this comment

We now "have" whether...

should be

We now "know" whether...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56151/new/

https://reviews.llvm.org/D56151





More information about the llvm-commits mailing list