[PATCH] D55078: Add omp_pause_resource* API

[Kelvin Li via Phabricator via llvm-commits]

kkwli0 added inline comments.


================
Comment at: openmp/trunk/runtime/src/include/50/omp_lib.h.var:44
       parameter(omp_allocator_kind=int_ptr_kind())
+      integer, parameter :: omp_pause_resource_kind = omp_integer_kind
 
----------------
Should use the same syntax (declaration + parameter statement) as the others in this file.


================
Comment at: openmp/trunk/runtime/src/include/50/omp_lib.h.var:143
+      integer (kind=omp_pause_resource_kind), parameter :: omp_pause_soft = 1
+      integer (kind=omp_pause_resource_kind), parameter :: omp_pause_hard = 2
+
----------------
AndreyChurbanov wrote:
> pawosm01 wrote:
> > These three lines are too long causing OpenMP test cases from Flang fortran compiler to fail. See how this problem is addressed in the lines above and below.
> Paul, sorry about that.  I've missed on review that these lines exceed 72 chars.
> Now fixed by commit rL351745.
declaration + parameter statement


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55078/new/

https://reviews.llvm.org/D55078