[PATCH] D56403: add pragmas to control Software Pipelining optimisation

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon accepted this revision.
bcahoon added a comment.
This revision is now accepted and ready to land.

Just a couple of minor comments on formatting. Otherwise, it looks good to me. Thanks!



================
Comment at: include/llvm/CodeGen/MachinePipeliner.h:66
   RegisterClassInfo RegClassInfo;
+  bool disabledByPragma = false;
+  unsigned II_setByPragma = 0;
----------------
DisabledByPragma - variable names should start with an upper case letter according to the LLVM Coding Standards.


================
Comment at: include/llvm/CodeGen/MachinePipeliner.h:86
+  MachinePipeliner()
+      : MachineFunctionPass(ID), disabledByPragma(false), II_setByPragma(0) {
     initializeMachinePipelinerPass(*PassRegistry::getPassRegistry());
----------------
I don't think you need (or should have) both default member initializer for disabledByPramga/II_setByPragma and a member initializer list.  I believe LLVM encourages using the default member initializer.


================
Comment at: lib/CodeGen/MachinePipeliner.cpp:365
+
+  if (II_setByPragma > 0) {
+    MII = II_setByPragma;
----------------
no need for braces


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56403/new/

https://reviews.llvm.org/D56403