[PATCH] D57006: [llvm-objcopy] [COFF] Update symbol indices in weak externals

Mon Jan 21 04:29:32 PST 2019

mstorsjo updated this revision to Diff 182776.
mstorsjo added a comment.

Going with `%s` together with `StringRef::str()` + `.c_str()` for formatting. Will use this form for later change to unify on `createStringError()` then.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57006/new/

https://reviews.llvm.org/D57006

Files:
  test/tools/llvm-objcopy/COFF/weak-external.test
  tools/llvm-objcopy/COFF/Object.h
  tools/llvm-objcopy/COFF/Reader.cpp
  tools/llvm-objcopy/COFF/Reader.h
  tools/llvm-objcopy/COFF/Writer.cpp
  tools/llvm-objcopy/COFF/Writer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57006.182776.patch
Type: text/x-patch
Size: 7653 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190121/620f90be/attachment.bin>