[PATCH] D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false

Dmitry Venikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 20 23:32:23 PST 2019


Quolyk marked 3 inline comments as done.
Quolyk added inline comments.


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:212
+  if (ClNoDemangle.getPosition() > ClDemangle.getPosition())
+    ClDemangle = !ClNoDemangle;
+
----------------
jhenderson wrote:
> What does `getPosition` do if the option is not on the command-line?
If option is not specified, cl::opt::getPosition() == 0.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56773/new/

https://reviews.llvm.org/D56773





More information about the llvm-commits mailing list