[PATCH] D56942: Change TPI Bucket size for PDBs from minimum to maximum

Sat Jan 19 10:37:31 PST 2019

aganea added a comment.

Thank you for this @CJHebert !

I was wondering:

1. Can we do an adaptative scheme, based on `TypeHashes.size()`? Some of us have lots of DLL loaded in the process, this might unlessly increase the debugger's memory usage.
2. Is `MaxTpiHashBuckets - 1` (why not `MaxTpiHashBuckets` rather?) really a hard limit, or would VS support higher values?

In D56942#1363926 <https://reviews.llvm.org/D56942#1363926>, @CJHebert wrote:

> For context, this took the time for cold symbol look up for chrome.pdb from 10 minutes down to 2 minutes.

3. What takes 2 min? For the VS debugger to lookup a symbol when you debug break?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56942/new/

https://reviews.llvm.org/D56942