[PATCH] D56621: [hwasan] Madvise away thread aux data

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 18 19:24:20 PST 2019


pcc added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan_thread_list.h:186
     uptr align = ring_buffer_size_ * 2;
     uptr ring_buffer_start = RoundUpTo(free_space_ + sizeof(Thread), align);
     free_space_ = ring_buffer_start + ring_buffer_size_;
----------------
Would it help to release memory starting from the original value of `free_space_` here? It seems that you would be able to probabilistically free a fraction of a page more that way. Or am I missing something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56621/new/

https://reviews.llvm.org/D56621





More information about the llvm-commits mailing list