[PATCH] D56031: [elfabi] Add support for reading dynamic symbols from binaries

[Armando Montanez via Phabricator via llvm-commits]

amontanez updated this revision to Diff 182649.
amontanez marked 8 inline comments as done.
amontanez added a comment.

Addressed most of your comments, but I've left the ELF/SYSV hash table in since it amounts to 12 additional lines for now. I can pull it out later if that's really needed. I feel it's relevant and small enough to leave in.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56031/new/

https://reviews.llvm.org/D56031

Files:
  llvm/test/tools/llvm-elfabi/Inputs/gnu_hash.so
  llvm/test/tools/llvm-elfabi/Inputs/sysv_hash.so
  llvm/test/tools/llvm-elfabi/binary-read-syms-gnu-hash.test
  llvm/test/tools/llvm-elfabi/binary-read-syms-sysv-hash.test
  llvm/tools/llvm-elfabi/ELFObjHandler.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56031.182649.patch
Type: text/x-patch
Size: 11077 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190119/e5a2570a/attachment.bin>