[PATCH] D56942: Change TPI Bucket size for PDBs from minimum to maximum

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 18 15:23:41 PST 2019


zturner accepted this revision.
zturner added subscribers: aganea, rnk.
zturner added a comment.
This revision is now accepted and ready to land.

Excellent find!  Alexandre Ganea (cc'ed) reported to me offline that he had seen degraded watch-window performance when using clang-cl generated code, but we only had some guesses as to what was causing it (none of which was this).  However, after reading your explanation, I'm pretty certain it had to be this.  I don't think we would have discovered this without your patch, so thanks!

Do you have commit access?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56942/new/

https://reviews.llvm.org/D56942





More information about the llvm-commits mailing list