[PATCH] D56929: lld-link: Use just one code path to process associative comdats, reject some invalid associated comdats

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 18 13:03:45 PST 2019


thakis marked an inline comment as done.
thakis added inline comments.


================
Comment at: lld/COFF/InputFiles.cpp:235
+    COFFObj->getSymbolName(Sym, Name);
+    COFFSymbolRef ParentSym = check(COFFObj->getSymbol(ParentSection));
+    COFFObj->getSymbolName(ParentSym, ParentName);
----------------
Oh, this is probably wrong. ParentSection is a section index, not a symbol index. One sec...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56929/new/

https://reviews.llvm.org/D56929





More information about the llvm-commits mailing list