[PATCH] D56840: [llvm-objcopy] [COFF] Implement --only-keep-debug

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked 3 inline comments as done.
mstorsjo added inline comments.


================
Comment at: test/tools/llvm-objcopy/COFF/only-keep-debug.test:5
+RUN: llvm-readobj --sections %t.out.exe | FileCheck %s --check-prefix=SECTIONS
+RUN: llvm-objdump -t %t.out.exe | FileCheck %s --check-prefix=SYMBOLS
+
----------------
jhenderson wrote:
> You don't need to change this, but the GNU style of llvm-readobj also provides symbol dumping in the style you are looking at. It may be useful to use that instead, if you want to keep things to one run of llvm-readobj.
Hmm, how do you activate that? Do you mean `--elf-output-style=GNU`, or something else? That one doesn't seem to have any effect when inspecting a COFF file.


================
Comment at: test/tools/llvm-objcopy/COFF/only-keep-debug.test:8
+Check that all non-debug/buildid sections with IMAGE_SCN_CNT_CODE
+or IMAGE_SCN_CNT_INITIALIZED_DATA are truncated, and none others.
+
----------------
jhenderson wrote:
> Oops, that should be "no others".
Oops, will fix before committing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56840/new/

https://reviews.llvm.org/D56840