[PATCH] D56912: Use llvm_canonicalize_cmake_booleans for LLVM_LIBXML2_ENABLED

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 18 11:41:21 PST 2019


mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.

Looks good. Optionally, I'm suggesting one cleanup.



================
Comment at: lld/test/lit.cfg.py:90
 # libxml2 to merge manifests.
 if (lit.util.which('cvtres', config.environment['PATH'])) or \
+        config.llvm_libxml2_enabled:
----------------
While at it, could you please replace this `\` with extra set of outer parentheses?

```
if (foo or
    bar):
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56912/new/

https://reviews.llvm.org/D56912





More information about the llvm-commits mailing list