[PATCH] D56819: Document toolchain update policy

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 20:08:11 PST 2019


hubert.reinterpretcast added inline comments.


================
Comment at: docs/DeveloperPolicy.rst:648
+codebase can use newer versions of C++ as they get standardized. Requiring newer
+toolchains to build LLVM can be painful for those building LLVM, it will
+therefore only be done through the following process:
----------------
smeenai wrote:
> Grammar nit: You either want a "Since" before the "Requiring", or a "so" after the comma and before the "it", otherwise the sentence flows weirdly.
I believe both //since// and //so// would be redundant with //therefore//. The flow can be fixed by using "; therefore, it will" instead of ", it will therefore".


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56819/new/

https://reviews.llvm.org/D56819





More information about the llvm-commits mailing list