[PATCH] D56828: [ELF] Make RW PT_LOAD start with PT_GNU_RELRO sections

Thu Jan 17 18:14:18 PST 2019

MaskRay added a comment.

In D56828#1361812 <https://reviews.llvm.org/D56828#1361812>, @ruiu wrote:

> Not sure why you want to implement a workaround at the moment. Can you elaborate? This is a bug in GNU binutils, and the fix was submitted almost a year ago. It looks like we should keep doing what we think right and don't implement too many workarounds.

Fixing GNU strip<2.31 was my motivation to investigate this issue but it is only a secondary reason why I propose this patch. The primary reason is that it can decrease 1 memory mapping (if `PT_GNU_RELRO` is in the middle, the `PT_LOAD` splits into 3 memory mappings), save some address space, and make it possible to let `PT_GNU_RELRO` have the same `p_memsz` and `p_filesz` in a future change.

I'll check other relro changes to see if this patch is reasonable and feasible.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56828/new/

https://reviews.llvm.org/D56828