[PATCH] D56886: [safestack] Remove dependency of SafeStack on sanitizer_common

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 16:36:08 PST 2019


eugenis added inline comments.


================
Comment at: compiler-rt/lib/safestack/safestack.cc:268
+class MutexLock {
+ public:
+  explicit MutexLock(pthread_mutex_t &mutex) : mutex_(&mutex) {
----------------
Nice! Consider moving SCS_CHECK, RoundUpTo and MutextLock to safestack_util.h or some other header.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56886/new/

https://reviews.llvm.org/D56886





More information about the llvm-commits mailing list