[PATCH] D56867: [ValueTracking] Early out of isValidAssumeForContext if the assume and the context instruction are the same

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

In D56867#1362336 <https://reviews.llvm.org/D56867#1362336>, @efriedma wrote:

> If we're going to do anything here, I'd prefer to change it to true, since that's the right answer... it seems like it isn't doing any harm in the meantime.


As I recall, it needs to be false. Otherwise, an assumption can imply the truth of its own argument and it will cause its own trivialization (and removal).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56867/new/

https://reviews.llvm.org/D56867