[PATCH] D56603: [HWASAN] Improve tag-mismatch diagnostics
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 17 15:53:51 PST 2019
eugenis accepted this revision.
eugenis added a subscriber: pcc.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/hwasan/hwasan_report.cc:415
mem_tag, t->unique_id());
+ Printf("Offset to first bad byte is in range [%zu, %zu)\n", offset,
+ Min(access_size,
----------------
This phrase sounds awkward. There should probably be a "the" before "first", at least... @pcc
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56603/new/
https://reviews.llvm.org/D56603
More information about the llvm-commits
mailing list