[PATCH] D56874: [WebAssembly] Fix windows compiler warning by using explicit 64bit shift. NFC.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 12:55:10 PST 2019


sbc100 updated this revision to Diff 182379.
sbc100 added a comment.

- feedback


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56874/new/

https://reviews.llvm.org/D56874

Files:
  wasm/OutputSegment.h
  wasm/Writer.cpp


Index: wasm/Writer.cpp
===================================================================
--- wasm/Writer.cpp
+++ wasm/Writer.cpp
@@ -691,7 +691,7 @@
   MemAlign = 0;
   for (OutputSegment *Seg : Segments) {
     MemAlign = std::max(MemAlign, Seg->Alignment);
-    MemoryPtr = alignTo(MemoryPtr, 1 << Seg->Alignment);
+    MemoryPtr = alignTo(MemoryPtr, 1ULL << Seg->Alignment);
     Seg->StartVA = MemoryPtr;
     log(formatv("mem: {0,-15} offset={1,-8} size={2,-8} align={3}", Seg->Name,
                 MemoryPtr, Seg->Size, Seg->Alignment));
Index: wasm/OutputSegment.h
===================================================================
--- wasm/OutputSegment.h
+++ wasm/OutputSegment.h
@@ -26,7 +26,7 @@
   void addInputSegment(InputSegment *InSeg) {
     Alignment = std::max(Alignment, InSeg->getAlignment());
     InputSegments.push_back(InSeg);
-    Size = llvm::alignTo(Size, 1 << InSeg->getAlignment());
+    Size = llvm::alignTo(Size, 1ULL << InSeg->getAlignment());
     InSeg->OutputSeg = this;
     InSeg->OutputSegmentOffset = Size;
     Size += InSeg->getSize();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56874.182379.patch
Type: text/x-patch
Size: 1083 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190117/25a81954/attachment.bin>


More information about the llvm-commits mailing list