[PATCH] D56867: [ValueTracking] Early out of isValidAssumeForContext if the assume and the context instruction are the same

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 12:28:43 PST 2019


efriedma added a comment.

Is it possible to write a testcase without the callbr patch?



================
Comment at: lib/Analysis/ValueTracking.cpp:549
+  if (Inv == CxtI)
+    return false;
+
----------------
I think we should return "true" here?  The condition of an assume should hold at the point the assume executes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56867/new/

https://reviews.llvm.org/D56867





More information about the llvm-commits mailing list