[PATCH] D56721: Move llvm-objdump demangle function into demangler library

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/trunk/lib/Demangle/Demangle.cpp:18
+  char *Demangled;
+  if (MangledName.compare(0, 2, "_Z") == 0)
+    Demangled = itaniumDemangle(MangledName.c_str(), nullptr, nullptr, nullptr);
----------------
erik.pilkington wrote:
> thakis wrote:
> > FWIW Itanium symbols can have up to 4 leading underscores. For example, `___Z10blocksNRVOv_block_invoke` is "___Z10blocksNRVOv_block_invoke" according to lib/Demangle.
> This is handled in a follow-up: https://reviews.llvm.org/D56855
And your `_Z3fooi` test is `__Z3fooi` on darwin, which you probably want to support as well.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56721/new/

https://reviews.llvm.org/D56721