[PATCH] D56762: [WebAssembly] Store section alignment as a power of 2

[Mark Searles via Phabricator via llvm-commits]

msearles added inline comments.


================
Comment at: lld/trunk/wasm/OutputSegment.h:29
     InputSegments.push_back(InSeg);
-    Size = llvm::alignTo(Size, InSeg->getAlignment());
+    Size = llvm::alignTo(Size, 1 << InSeg->getAlignment());
     InSeg->OutputSeg = this;
----------------
Looks like one of our internal windows builders is failing due to this change:

c:\buildagent\work\7a156dd62df26211\opencl\drivers\opencl\compiler\llvm\tools\lld\wasm\OutputSegment.h(29): error C2220: warning treated as error - no 'object' file generated
[00:38:36][Step 2/4] 

c:\buildagent\work\7a156dd62df26211\opencl\drivers\opencl\compiler\llvm\tools\lld\wasm\OutputSegment.h(29): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)

Perhaps it should be 1ULL , not 1 ? 
Trying to get onto our windows builder to test this.
Thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56762/new/

https://reviews.llvm.org/D56762