[PATCH] D54472: Disable invalid isPodLike<> specialization

[Arthur O'Dwyer via Phabricator via llvm-commits]

Quuxplusone added a comment.

LGTM!



================
Comment at: docs/ProgrammersManual.rst:1459
 
-#. SmallVector understands ``isPodLike<Type>`` and uses realloc aggressively.
+#. SmallVector understands ``is_trivially_copyable<Type>`` and uses realloc aggressively.
 
----------------
Bikeshed: This isn't technically an advantage over std::vector, since std::vector also does this. :)

I do think you should explicitly say `llvm::is_trivially_copyable<Type>` here, to distinguish it from `std::is_trivially_copyable<Type>` (which IIUC should not be used anywhere in the LLVM codebase). But maybe the `llvm::` qualification would be implicitly assumed by people who work with LLVM frequently?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54472/new/

https://reviews.llvm.org/D54472