[PATCH] D56858: [llvm-objdump][NFC] Improve readability.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 08:48:07 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two minor comments.



================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:273
 namespace {
+
+struct SectionSymbol {
----------------
Remove this blank line.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:275
+struct SectionSymbol {
+  SectionSymbol(uint64_t A, StringRef N, uint8_t T)
+      : Address(A), Name(N), Type(T) {}
----------------
Don't abbreviate these. You can use Address, Name, and Type in the signature.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56858/new/

https://reviews.llvm.org/D56858





More information about the llvm-commits mailing list