[PATCH] D55439: [MC] Do not consider .ifdef/.ifndef as a use
Kristina Brooks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 17 08:10:23 PST 2019
kristina added a reviewer: kristina.
kristina added a comment.
LGTM if GAS does allow multiple uses of `.set` to change the value. One nit on the test, can you add a case where you don't have an `.if` directive like:
.set foo, 5
#CHECK: .byte 5
.byte foo
I think it would make sense to have that at the bottom even if there is already a test for it, just to verify that plain `.set` semantics are still correct when preceded by several `.if`/`.else` directives.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55439/new/
https://reviews.llvm.org/D55439
More information about the llvm-commits
mailing list