[PATCH] D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added a comment.

In D40147#1352518 <https://reviews.llvm.org/D40147#1352518>, @grimar wrote:

> I am pretty sure we can land this because having a patch on a review for about a year is always a terrible thing. My comments are inline.


Thanks for review.

We cannot move call of `setMicroMipsBit` to the `MIPS::relocateOne` because the `relocateOne` does not have a reference to the "target" symbol. One possible solution is to extend the `getVA()` and `getPltVA()` routines and add a less-significant bit there when necessary. That eliminates almost all manipulations with the bit in other places and makes calls of the `setMicroMipsBit` routine unnecessary. It's interesting that this approach was implemented in the first version of this patch https://reviews.llvm.org/D40147?id=123236.

I will try to restore that version of the patch.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D40147/new/

https://reviews.llvm.org/D40147