[PATCH] D56853: [llvm-objdump] - Show aliases in -help.

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: zturner, labath, rnk, rupprecht, davide, erik.pilkington.

Currently `llvm-objdump` is inconsistent.

When -help is specified it shows no aliases except two.
Aliases are shown with `-help-hidden` though.
GNU objdump also prints them by default.

This patch does a change to always show all aliases when `-help` is given.

I included no test case because seems there is no good way to test it:

- Does not seem we want to test the whole -help output. It seems an overkill.
- Does not seem we want to test only lines with the aliases, because it is brittle

and would be easy to forget to update such test case.

- In LLD we test a single option:

https://github.com/llvm-mirror/lld/blob/master/test/ELF/help.s
IMO it is not very useful actually. It effectively tests that we print at least one alias.
It does not save from any mistakes.


https://reviews.llvm.org/D56853

Files:
  tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56853.182279.patch
Type: text/x-patch
Size: 7729 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190117/652fa871/attachment.bin>